nvme-print: update list-subsys output for iopolicy #3010
Conversation
Before commit d0b4c6c, the iopolicy was displayed only in the verbose regular/json outputs of the list-subsys commands, similar to what is currently seen for the show-topology verbose outputs. But now, iopolicy is seen in the list-subsys regular output itself conflicting with its corresponding json output. So to maintain consistency across the board, move the iopolicy to the verbose output itself for the list-subsys command. Signed-off-by: Martin George <[email protected]>
|
From the commit message I understand that @shroffni would like to see iopolicy all the time. I don't have a strong opinion but would like to avoid adding too much on the default output. I think it would be safe to add the iopolicy field to the default json output, this should not break any parser. I am fine with either solution: go back to the old behavior or add extend the json output. |
Exactly. We display so many other subsys attributes such as model, firmware, type, etc. under the verbose option. So why should iopolicy alone remain under the regular output - it only serves to crowd up the regular output more which is unnecessary and an eye sore. Ideally, the regular output should always be brief and concise. Detailed output should be under the verbose option itself as much as possible.
I'd prefer sticking to the old behavior itself of displaying all subsys attributes (including iopolicy) under the verbose option itself - no reason to make iopolicy alone an exception here. |
2 participants
Before commit d0b4c6c, the iopolicy was displayed only in the verbose regular/json outputs of the list-subsys commands, similar to what is currently seen for the show-topology verbose outputs. But now, iopolicy is seen in the list-subsys regular output itself conflicting with its corresponding json output. So to maintain consistency across the board, move the iopolicy to the verbose output itself for the list-subsys command.